Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): use scoped package path in vscode debugger scripts #524

Merged
merged 2 commits into from Jul 5, 2018
Merged

fix(cli): use scoped package path in vscode debugger scripts #524

merged 2 commits into from Jul 5, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jul 5, 2018 •
edited by ghost
Loading

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:
The current paths for the 5.x branch.
I'm not sure if the windows paths are correct, please verify.

@ghost
Copy link
Author

ghost commented Jul 5, 2018

Uggh the windows newline. Lemme see if i can fix that.

MarshallOfSound
MarshallOfSound approved these changes Jul 5, 2018
View reviewed changes
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@ghost
Copy link
Author

ghost commented Jul 5, 2018 •
edited by ghost
Loading

I don't think they were using windows style newlines from the start, but shouldn't they have been?

Also, the shell script SHOULD have an EOF newline.

@MarshallOfSound MarshallOfSound merged commit f1b90b6 into electron:master Jul 5, 2018
dsanders11 pushed a commit that referenced this pull request Jan 14, 2023
@issacgerges
fix: re-work output dom to remove whitespace when copying (#524)
fc25926 
Co-authored-by: Issac Gerges <gergesim@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MarshallOfSound